So i have a 96xj 170k on it it had new MC, brake calipers, and rear wheel cylinders. Don't know what to do next brakes still soft. There soft as i press them then get a little firm and slowly sink after.

 

Did you adjust up rears ?

 

I'm assuming that you bled them? How old is the fluid? You might need to change the fluid and flush the system.

 

It's been a while I'll do it after work but my brake light is on as well and they pull sometimes

 

Brake light being ons a good sign rear brakes are in need of attention ,pulling would be the front line since everything else is new.

 

did you bench bleed the master cylinder before installing it?

 

I bet you a few $$$ you didnt bleed the valve assembly...
I have been chasing the same soft brake peddle issue and found that bleeder on there.


Just question before advice arrives:
with the engine off does your brake pedal become firm when pumped a few times? and no leaks anywhere?

- adjust the rear brake shoes
- Blench bleed the MC before install
- bleed the valve assembly (bleeder in front facing the radiator) after MC has been installed
-Do a thorough and decent bleed procedure on the system, starting with wheel furthest away from MC and ending with the wheel closest. If you generously bleed, you will have your flush at the same time refereshing your old fluid

Yes, there is an adjustable rod that goes (from the brake booster) into the MC, that is sometimes advised to adjust.
Another side thing is your OEM rubber brake hoses in front...as time goes by, the aging lines will add to the softness of your brake pedal.

My bet is still air in the system somewhere....

 

Listen to Roler ^^^^

 

Okay so no leaks, brake it's firm with engine off tried pumping still nice and firm. I am going to get all new ss lines. But about this bleeder valve assembly where it's it located exactly??

 

Did you adjust rears yet ? Proper adjustment of rear shoe regulates pedal height after this is done then re bleed system in normal order ,PR DR PF DF .

 

Like I said....first step in the process.

 

Okay ima buy new rear shoes, adjust, and then bleed again. Hopefully all is good

 

let us know how you go....and remember: bleed ALL the components (you'll be surprised how much air will be in your valve assembly . Bleeding that assembly I would use the two-person-method.

 

Definitely let ya know

 

New shoes will not cure soft pedal. But if you need them, go ahead.

Like other posters have said, you've still got air in the system.