Hey I have a 96 xj that won't start it just keeps cranking, iv already replaced the ignition coil, starter, battery, cps, nss, full pump and filter and still nothing anyone have any ideas?

I see you didn't mention spark plugs, wires, rotor/cap, or IAC. When my IAC died I had to feather the gas to get it to start, then had to keep on the gas or it'd stall - otherwise it would just sit and crank.

Instead of throwing parts at it, you need to adopt a "testing strategy".

Job #1 is to check for spark. Pull a plug, keep it attached to the plug wire, place the plug electrode near a good engine ground, have a buddy crank the engine while you watch. You are looking for a strong, blue, snapping spark. Yellow/orange/white indicates a weak spark, which may not be strong enough to start the engine.

If spark checks out (and only if), then try spraying a small amount of starting fluid into the intake. If the engine starts and runs for a little bit using this technique, you have identified a "fuel delivery" problem.

The above two tests are essential in determining root cause of your no-start.

Good luck and let us know what you find!

Thank you for all the info ill let you know what I find out.

I had similar experience, it was a bad cell battery, replaced that and the front 02. Fires perfect now...