Getting to know a 96 xj I bought a week ago. Investigating a rattle, I looked at my front suspension. It looks like something is missing from inside the coils. There's a large shock behind, and in the back there's shocks and leaf springs. am I missing something? Is this jeep lifted?

 

Upper bump stop looks like it has something going on but if the hardware is tight you should hear a rattle.

You best bet is to grab a jack some jack stands and a buddy. And do some poking around unless you don't have a working knowledge of what the underside of the Jeep should look like, then in that case maybe some one on here who is close can be "bribed" into showing you around the Jeep.

But you'll need the right sign and incentive.

 

Looks like the bump stop is rotted off. There should be a bullet shaped rubber piece at the end of the tube in the center of the spring which stops the upward movement of the axle when the suspension flexes to the maximum deflection. Without it you might rub the tire on the upper part of the inner fender, but you would need to be going over a large rut or obstacle with stock sized tires. If you have oversize tires then it becomes more critical, and if they are large enough you need extended stops to prevent rubbing.

https://www.cherokeeforum.com/f2/bump-stop-help-43714/

Scroll down a few posts and you will see that it should look like.

 

That is the front bump stop tower..the end should have a little rubber bun at the end like in pic.





here is a link for new ones

http://www.ebay.com/itm/Omix-ADA-182...del%3ACherokee

 

Thanks guys :-)

 

that won't make it rattle tho, most common rattle in vehicles would be the sway bar ends. it's that metal rod thing to the right of your spring in the pic.
make sure it's tight at both ends. you can use a pry bar or simply rock the jeep while on the ground to see/hear the knocking/rattling.