​​I will do my best to explain everything in this post.

(Before anything side note) I have been dealing with the battery dieing since I swapped my driver's rear door. (Probably not this issue but a separate one.)

Today I seafoamed the engine the way I watched someone do it online with their 4.0 I dumped some In the gas let it run and reved to 2000rpm and idle a few times. Noticed the idle improved a little (sweet I thought) continuing on with what the video did poured some into the throttle body. It killed the engine doing that. (The video said expect that) I started it. Didnt want to so i pressed on the gas a little. Started up. Let it idle for a few reved it to 2000rpm then white smoke came from center console??? Didn't smell of burnt plastic. Didn't cause a fire. Was on the passenger side. I considered it came throught a hole in the floor. No more smoke after that small cloud. Turned it off.
The seafoam didn't make my exhaust smoke like the video maybe because I have rebuilt my entire exhaust recently.
Well go to start about 15 minutes later after I check the engine and body and electrical out. No crank no start.
The battery powers fuel pump. Doors. All the lights. And radio normally.
Checked fuses and relays all good. Tried to charge battery a cheapo tester friend has says it was good hattery. Hit starter with a hammer when friend turns key it Sparks no crank.
we think may be starter (put in a carquest new one last summer for it) drove it a few times short distances trying to make sure it's full ready for daily driving/ and weekly up to Michigan to see my son. Plus nautrally offroading when I know it's ready.
Bought this Jeep last summer since then I have
Put a autocraft gold battery 800cca and new terminals and new starter both under warranty
I have replaced power steering pump and lines.
Entire exhaust and engine motor mounts
Accell cap rotor and wires
Oe style champion plugs gapped anti siezed and torqued
Last week cleaned throttle body with crc throttle body cleaner a toothbrush, q tips and shop rags. With a new gasket of course
New fuel filter and because of old gas added gas and decided to give seafoam a shot only heard good about it.
has 749 neon injectors from friend installed before I bought it.
Ordered the proper 703 injectors since my obd1 code is only reading #27 and I learned what proper injectors I need and they will arrive tomorrow I'll give him the neons I have now for his 99 xj.
All interior lights swapped to LEDs and have replaced door jamb switches and swapped left front fender and left rear door.
Swapped the dash and fixed all gagues.
Fixed almost every electrical issue I've came across except rear wiper switch plan to soon and the rear doors electric locks are barely responsive so I manually unlock them when I need in the back.
Almost entire cooling system replaced
about to do tranny filter,transfer fluid, diff fluids. And brakes/lines and Lift kit.

I am not sure why it is not starting thinking it's the starter.

My plan take battery to my work in morning put on the dtac and test it. And ask my coworker who is 40+ years experience his thoughts on this.
Then go to advance my second job and bench test my starter, if bad warranty it out.

​​​​​​I hope this is enough information for you guys. Please give me your thoughts and opinions.
i just got the Jeep legal and really want to be able to start using it (my favorite vehicle besides the jks and 2 door sports) ​​​​​

 

Have you tried starting in neutral? Could be completely unrelated to all the stuff you've done and just be that your NSS is acting up. Tapping on the NSS with a wrench can also be helpful. If this solves your problem then you'll need to rebuild your neutral safety switch soon.

 

No I have not. I will check into that while I am on my break between the shop and parts store. Thank you.

 

This morning got in it and no crank shifted to neutral nothing happened. Shifted through all the gears and tried again in park it make a single crank sound. I bet you are right on that one. I took the battery with me to test on the machine and charge then I'll see if that helps. If not I still plan to test that starter since I have the bench tester at my other job. But in the mean time I am looking at prices online and different stores to see what my best option for this neutral safety switch is. First I will tear mine apart and clean it up see how it works after that and if it is fixed right up no more problems I will be buying a new one. If not I may buy a new one just to swap out since like everything else on this it's probably 24 years old

 

if your motor cranked even once while fiddling the auto shifter it is the NSS for sure

taking them apart and clean up is an easy fix,

put trans in neutral helps to get switch out, dont be tempted to pry on its plastic

 

I will do that. The mechanic at my stepfather's shop I work at who has 40+ years experience immediately told me to take my multimeter and check my starter and if needed trace it back to the relay, ignition switch, to the battery... You know as needed. Before I leave work for the evening we are going to print out a wiring diagram so while I'm at the parts store wasting my evening with that stupidity I can look over the diagram. Tomorrow I work 8-5 at the shop so I'll have plenty of time in the evening to clean up the neutral safety switch and test my electrical connections. Plus my 703 neon injectors are supposed to arrive today! I am excited for tomorrow with hopes I get this issue solved )

 

Fixed the issue. I had bad ground cables so I replaced them entirely and replaced battery terminals cleaned the starter connections and now it runs :3