when i turn the key theirs power it was doing this on & off at the worse times but it would start(crank) after a few min. until tuesday when it wouldnt start at all so i changed the starter & cps still no crank..
could it be ignition switch?
not battery,starter or cps

 

Before you changed the starter did you check the old one to see if it was the problem?

 

yea it was dead

 

If the battery and starter are good and you can jump across the terminal at the starter and it cranks over the engine then I'd look at ign switch, while the problems you stated seem to lead somewhere else, I would start with Batt, ground, starter, switch in that order.

 

Clean your battery terminals. I've had plenty of problems with both my xj's where the battery cables are tight but there isn't a good connection so get the $1 battery terminal scuffer and give it a go.