im at my end
 

so i fixed the fuel pump and now i cant get it to idle any answers, let me now what u think

got a little more info?

Need more information.
 

No idling could be due to any number of things .The first that comes to my tiny mind is a BIG vacuum leak. Does the engine even start? How is the charge on the battery?( The field coils on the alternator will not energize with out enough voltage) Help us help you by suppling more details,we are not mind readers.

the battery is great its got a optima red top, i was thinking the same thing (vacuum leak) i havent got to check for that yet, i was also thinkin knock sensor. i wasnt gettin any power to the relay for the fuel pump so i built my on circuit for it with a relay and a blade fuse, so i know im getting fuel, i checked the fuel rail also and im good there. but sometimes it will idle fine, no spitting or sputtering but then it just shuts off, could this be due to a faulty IAC (idle air control)???

if its an older xj i would try changing the ballest resistor

mines an 88

and i made my own circuit would the ballest resistor still matter